From 361d634c22866541c843986b543f236e1de9cd56 Mon Sep 17 00:00:00 2001 From: m_broelemann Date: Wed, 6 Jan 2021 13:19:39 +0100 Subject: [PATCH 1/9] =?UTF-8?q?Slide=20Bar=20f=C3=BCr=20DutyCycle=20einste?= =?UTF-8?q?llen=20erstellt?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- APED/app/build.gradle | 2 +- .../src/main/res/layout/alert_dialog_pwm.xml | 31 +++++++++++++++++++ 2 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 APED/app/src/main/res/layout/alert_dialog_pwm.xml diff --git a/APED/app/build.gradle b/APED/app/build.gradle index b1bc785..32095a7 100644 --- a/APED/app/build.gradle +++ b/APED/app/build.gradle @@ -31,7 +31,7 @@ android { dependencies { implementation 'androidx.appcompat:appcompat:1.1.0' - implementation 'com.google.android.material:material:1.1.0' + implementation 'com.google.android.material:material:1.3.0-beta01' implementation 'androidx.constraintlayout:constraintlayout:1.1.3' implementation 'androidx.navigation:navigation-fragment:2.2.2' implementation 'androidx.navigation:navigation-ui:2.2.2' diff --git a/APED/app/src/main/res/layout/alert_dialog_pwm.xml b/APED/app/src/main/res/layout/alert_dialog_pwm.xml new file mode 100644 index 0000000..0a06c8b --- /dev/null +++ b/APED/app/src/main/res/layout/alert_dialog_pwm.xml @@ -0,0 +1,31 @@ + + + + + + + + + \ No newline at end of file From feda184aa5b845a0fe52b959712f1e6a8e15a8f5 Mon Sep 17 00:00:00 2001 From: m_broelemann Date: Wed, 6 Jan 2021 17:09:33 +0100 Subject: [PATCH 2/9] =?UTF-8?q?Steuerung=20der=20PWM=20und=20Restruckturie?= =?UTF-8?q?rung=20des=20codes=20und=20kleinere=20Visualisierungs=C3=A4nder?= =?UTF-8?q?ungen?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../ui/visualization/MainListViewAdapter.java | 84 ++----- .../aped/ui/visualization/PinView.java | 230 +++++++++++------- 2 files changed, 159 insertions(+), 155 deletions(-) diff --git a/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java b/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java index d08a52f..2537496 100644 --- a/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java +++ b/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java @@ -95,99 +95,53 @@ public class MainListViewAdapter extends BaseAdapter { @Override public View getView(final int i, View view, final ViewGroup viewGroup) { - view = mainActivity.getLayoutInflater().inflate(R.layout. - listview_layout, null); - TextView textViewName = (TextView) view.findViewById( - R.id.textName); - LinearLayout linearLayoutPin = (LinearLayout) view.findViewById( - R.id.idLinearLayoutPins); - ImageView buttonViewFavoriten = (ImageView) view.findViewById( - R.id.imageButtonFavoriten); + view = mainActivity.getLayoutInflater().inflate(R.layout.listview_layout, null); + TextView textViewName = (TextView) view.findViewById(R.id.textName); + LinearLayout linearLayoutPin = (LinearLayout) view.findViewById(R.id.idLinearLayoutPins); + ImageView buttonViewFavoriten = (ImageView) view.findViewById(R.id.imageButtonFavoriten); if (favoriteMode == 0) { deviceName = mainActivity.xml.getDeviceNames().get(i); } else { deviceName = mainActivity.favorite.getFavorites().get(i); } - if (mainActivity.favorite.getFavorites().contains( - deviceName)) { + if (mainActivity.favorite.getFavorites().contains(deviceName)) { favoriteImage = android.R.drawable.btn_star_big_on; } else { favoriteImage = android.R.drawable.btn_star_big_off; } - - buttonViewFavoriten.setOnClickListener( - new View.OnClickListener() { + buttonViewFavoriten.setOnClickListener(new View.OnClickListener() { @Override public void onClick(final View view) { if (favoriteMode == 0) { - deviceName = mainActivity.xml.getDeviceNames(). - get(i); + deviceName = mainActivity.xml.getDeviceNames().get(i); } else { List test = favoritenList; deviceName = favoritenList.get(i); } - if (mainActivity.favorite.getFavorites().contains( - deviceName)) { - mainActivity.favorite.removeFavorite( - deviceName); - favoriteImage = android.R.drawable.btn_star_big_off; - buttonViewFavoriten.setImageResource( + if (mainActivity.favorite.getFavorites().contains(deviceName)) { + mainActivity.favorite.removeFavorite(deviceName); + favoriteImage = android.R.drawable.btn_star_big_off;buttonViewFavoriten.setImageResource( favoriteImage); } else { - mainActivity.favorite.addFavorite( - deviceName); + mainActivity.favorite.addFavorite(deviceName); favoriteImage = android.R.drawable.btn_star_big_on; - buttonViewFavoriten.setImageResource( - favoriteImage); + buttonViewFavoriten.setImageResource(favoriteImage); } } }); - - mainActivity.uebergabe.read(deviceName, - new Response.Listener() { - @Override - public void onResponse(final JSONObject response) { - if (favoriteMode == 0) { - deviceName = mainActivity.xml.getDeviceNames().get(i); - } else { - deviceName = mainActivity.favorite.getFavorites().get(i); - } - try { - JSONObject state = response.getJSONObject("state"); - List pinValues = new ArrayList<>(); - for (String pinName: ((List) mainActivity.xml. - getPort(deviceName). - get("pins"))) { - pinValues.add(state.getString(pinName)); - } - PinView pinView = new PinView(mainActivity, deviceName, - pinValues); - for (int j = 0; j < ((List) mainActivity.xml. - getPort(deviceName). - get("pins")).size(); j++) { - linearLayoutPin.addView(pinView.getView(j)); - } - } catch (JSONException e) { - // Richtigen log erstellen - e.printStackTrace(); - } - - } - }); + PinView pinView = new PinView(mainActivity, deviceName); + for (int j = 0; j < ((List) mainActivity.xml.getPort(deviceName).get("pins")).size(); j++) { + linearLayoutPin.addView(pinView.getView(j)); + } String name = null; - switch ((mainActivity.xml.getPort(deviceName)).get("protocol"). - toString()) { + switch ((mainActivity.xml.getPort(deviceName)).get("protocol").toString()) { case "PWM": - name = ((mainActivity.xml.getPort(deviceName)).get("protocol"). - toString() + ": " + deviceName + " (" + (mainActivity. - xml.getPort(deviceName)).get("frequency").toString() - + "Hz)"); + name = ((mainActivity.xml.getPort(deviceName)).get("protocol").toString() + ": " + deviceName + " (" + (mainActivity.xml.getPort(deviceName)).get("frequency").toString() + "Hz)"); break; default: - name = ((mainActivity.xml.getPort(deviceName)).get("protocol"). - toString() + ": " + deviceName); + name = ((mainActivity.xml.getPort(deviceName)).get("protocol").toString() + ": " + deviceName); break; } textViewName.setText(name); diff --git a/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java b/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java index 9759e2c..048eaf1 100644 --- a/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java +++ b/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java @@ -1,13 +1,21 @@ package com.example.aped.ui.visualization; -import android.content.Intent; +import android.content.DialogInterface; +import android.text.Html; import android.view.View; +import android.widget.EditText; import android.widget.ImageView; import android.widget.TextView; import android.widget.Toast; + +import androidx.annotation.NonNull; + import com.android.volley.Response; import com.example.aped.MainActivity; import com.example.aped.R; +import com.google.android.material.dialog.MaterialAlertDialogBuilder; +import com.google.android.material.slider.RangeSlider; + import org.json.JSONException; import org.json.JSONObject; @@ -15,125 +23,167 @@ import java.util.ArrayList; import java.util.List; public class PinView { + /** + * Einbinden der MainActivity. + */ private MainActivity mainActivity; - + /** + * Statusbild für den atuellen durchlauf. + */ private int image; - private List pinValues; + /** + * Werte der Pins. + */ + private List pinValues = new ArrayList<>(); + /** + * Gerätenamen. + */ private String deviceName; + /** + * DutyCycle. + */ + private String dutyValue; - public PinView(MainActivity pMainActivity,String pDevice, List pPinValues){ + /** + * @param pMainActivity + * @param pDeviceName + */ + public PinView(final MainActivity pMainActivity, final String pDeviceName) { this.mainActivity = pMainActivity; - this.deviceName = pDevice; - this.pinValues = pPinValues; + this.deviceName = pDeviceName; } + /** + * @param i + * @return view + */ public View getView(final int i) { - View view = mainActivity.getLayoutInflater().inflate(R.layout.pin_listview_layout, - null); - ImageView imageView = (ImageView) view.findViewById( - R.id.images); - TextView textViewPin = (TextView) view.findViewById( - R.id.textPin); + dutyValue = ""; + View view = mainActivity.getLayoutInflater().inflate(R.layout.pin_listview_layout, null); + TextView textViewPin = (TextView) view.findViewById(R.id.textPin); + textViewPin.setText(((List) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i)); + mainActivity.uebergabe.read(deviceName, new Response.Listener() { + @Override + public void onResponse(final JSONObject response) { + displayLamp(response, view, i); + if((mainActivity.xml.getPort(deviceName)).get("protocol").toString().equals("PWM")){ + textViewPin.setText(Html.fromHtml(((List) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i)+" (DC: " + pinValues.get(i) + "%) ")); + } + } + }); view.setOnClickListener(new View.OnClickListener() { @Override public void onClick(final View view) { - if((mainActivity.xml.getPort(deviceName)).get("protocol").toString().equals("DO")) { - try {// Werte erst aktualisieren + switch ((mainActivity.xml.getPort(deviceName)).get("protocol").toString()) { + case "DO": + try { String setState = null; - if(pinValues.get(i).equals("0")) { - setState = "{\"output\": \"1\"}"; - }else{ - setState = "{\"output\": \"0\"}"; + if (pinValues.get(i).equals("0")) { + setState = "\"1\""; + } else { + setState = "\"0\""; } - JSONObject jsonObject = new JSONObject(setState); + JSONObject jsonObject = new JSONObject("{\"output\":{\"" + ((List) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i) + "\":" + setState + "}}"); mainActivity.uebergabe.write(deviceName, jsonObject, new Response.Listener() { @Override - public void onResponse(JSONObject response) { - try { - if (!jsonObject.equals(response)) { - // Fehler - } - switch (response.getInt("output")){ - case 1: - image = R.drawable.green_signal; - break; - case 0: - image = R.drawable.red_signal; - break; - default: - image = R.drawable.off_signal; - break; - } - imageView.setImageResource(image); - - } catch (JSONException e) { - e.printStackTrace(); - } + public void onResponse(final JSONObject response) { + displayLamp(response, view, i); } }); } catch (JSONException e) { e.printStackTrace(); } - - }else{ - Toast.makeText(mainActivity, deviceName - + " is not an output " , - Toast.LENGTH_SHORT).show(); - } - mainActivity.uebergabe.read(deviceName, - new Response.Listener() { - @Override - public void onResponse(final JSONObject response) { - try { - JSONObject state = response.getJSONObject("state"); - //List pinValues = new ArrayList<>(); - pinValues.clear(); - for(String pinName: ((List)mainActivity.xml. - getPort(deviceName). - get("pins"))){ - pinValues.add(state.getString(pinName)); + break; + case "PWM": + MaterialAlertDialogBuilder alert = new MaterialAlertDialogBuilder(mainActivity); + View viewAlert = mainActivity.getLayoutInflater().inflate(R.layout.alert_dialog_pwm, null); + RangeSlider readDuty = (RangeSlider) viewAlert.findViewById(R.id.range_slider_duty); + readDuty.setValues((float) Float.valueOf(pinValues.get(i))); + alert.setView(viewAlert); + alert.setPositiveButton("set", + new DialogInterface.OnClickListener() { + public void onClick( + final DialogInterface dialog, final int which) { + int value = readDuty.getValues().get(0).intValue(); + try { + JSONObject jsonObject = new JSONObject("{\"output\":{\"" + ((List) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i) + "\":\"" + value + "\"}}"); + mainActivity.uebergabe.write(deviceName, jsonObject, new Response.Listener() { + @Override + public void onResponse(JSONObject response) { + displayLamp(response, view, i); + textViewPin.setText(Html.fromHtml(((List) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i)+" (DC: " + pinValues.get(i) + "%) ")); + } + }); + } catch (JSONException e) { + e.printStackTrace();// aaaaa } - switch (pinValues.get(i)){ - case "1": - image=R.drawable.green_signal; - break; - case "0": - image=R.drawable.red_signal; - break; - default: - image=R.drawable.off_signal; - break; - } - imageView.setImageResource(image); - - } catch (JSONException e) { - // Richtigen log erstellen - e.printStackTrace(); + // Write your code here to execute after dialog + dialog.cancel(); } + }); + alert.setNegativeButton("exit", new DialogInterface.OnClickListener() { + public void onClick( + final DialogInterface dialog, final int which) { + dialog.cancel(); + } + }); + alert.show(); + break; + default: + Toast.makeText(mainActivity, deviceName + " is not an output ", Toast.LENGTH_SHORT).show(); + break; + } + - } - }); } }); - switch (pinValues.get(i)){ - case "1": - image=R.drawable.green_signal; - break; - case "0": - image=R.drawable.red_signal; - break; - default: - image=R.drawable.off_signal; - break; - } - imageView.setImageResource(image); - textViewPin.setText(((List) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i)); + + return view; - } + + +} + + + private void displayLamp(final JSONObject response, final View view, final int i) { + ImageView imageView = (ImageView) view.findViewById(R.id.images); + try { + JSONObject state = response.getJSONObject("state"); + if (pinValues.size() != 0) { + pinValues.clear(); + } + for (String pinName: ((List) mainActivity.xml.getPort(deviceName).get("pins"))){ + pinValues.add(state.getString(pinName)); + } + switch (pinValues.get(i)) { + case "1": + image = R.drawable.green_signal; + break; + case "0": + image = R.drawable.red_signal; + break; + case "100": + image = R.drawable.green_signal; + break; + default: + image = R.drawable.off_signal; + break; + } + imageView.setImageResource(image); + + } catch (JSONException e) { + // Richtigen log erstellen + e.printStackTrace(); + } + + } + + + } From a0ac5d4d0e65b7732ae9bc5946ebb4eab5fa9b6b Mon Sep 17 00:00:00 2001 From: m_broelemann Date: Wed, 6 Jan 2021 17:19:21 +0100 Subject: [PATCH 3/9] Code Conventions --- .../aped/ui/visualization/PinView.java | 238 ++++++++++-------- 1 file changed, 132 insertions(+), 106 deletions(-) diff --git a/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java b/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java index 048eaf1..00793e4 100644 --- a/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java +++ b/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java @@ -3,22 +3,16 @@ package com.example.aped.ui.visualization; import android.content.DialogInterface; import android.text.Html; import android.view.View; -import android.widget.EditText; import android.widget.ImageView; import android.widget.TextView; import android.widget.Toast; - -import androidx.annotation.NonNull; - import com.android.volley.Response; import com.example.aped.MainActivity; import com.example.aped.R; import com.google.android.material.dialog.MaterialAlertDialogBuilder; import com.google.android.material.slider.RangeSlider; - import org.json.JSONException; import org.json.JSONObject; - import java.util.ArrayList; import java.util.List; @@ -60,130 +54,162 @@ public class PinView { */ public View getView(final int i) { dutyValue = ""; - View view = mainActivity.getLayoutInflater().inflate(R.layout.pin_listview_layout, null); + View view = mainActivity.getLayoutInflater().inflate(R.layout. + pin_listview_layout, null); TextView textViewPin = (TextView) view.findViewById(R.id.textPin); - textViewPin.setText(((List) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i)); - mainActivity.uebergabe.read(deviceName, new Response.Listener() { + textViewPin.setText(((List) (mainActivity.xml.getPort( + deviceName)).get("pins")).get(i)); + mainActivity.uebergabe.read(deviceName, new Response. + Listener() { @Override public void onResponse(final JSONObject response) { displayLamp(response, view, i); - if((mainActivity.xml.getPort(deviceName)).get("protocol").toString().equals("PWM")){ - textViewPin.setText(Html.fromHtml(((List) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i)+" (DC: " + pinValues.get(i) + "%) ")); + if ((mainActivity.xml.getPort(deviceName)).get("protocol"). + toString().equals("PWM")) { + textViewPin.setText(Html.fromHtml(((List) + (mainActivity.xml.getPort(deviceName)).get("pins")). + get(i) + " (DC: " + pinValues.get(i) + "%) " + )); } } }); - view.setOnClickListener(new View.OnClickListener() { @Override public void onClick(final View view) { - switch ((mainActivity.xml.getPort(deviceName)).get("protocol").toString()) { - case "DO": + switch ((mainActivity.xml.getPort(deviceName)).get("protocol"). + toString()) { + case "DO": try { - String setState = null; - if (pinValues.get(i).equals("0")) { - setState = "\"1\""; - } else { - setState = "\"0\""; - } - JSONObject jsonObject = new JSONObject("{\"output\":{\"" + ((List) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i) + "\":" + setState + "}}"); - mainActivity.uebergabe.write(deviceName, jsonObject, new Response.Listener() { - @Override - public void onResponse(final JSONObject response) { - displayLamp(response, view, i); + String setState = null; + if (pinValues.get(i).equals("0")) { + setState = "\"1\""; + } else { + setState = "\"0\""; } - }); - } catch (JSONException e) { - e.printStackTrace(); - } + JSONObject jsonObject = new JSONObject( + "{\"output\":{\"" + ((List) + (mainActivity.xml.getPort( + deviceName)).get("pins")). + get(i) + "\":" + setState + "}}"); + mainActivity.uebergabe.write(deviceName, jsonObject, + new Response.Listener() { + @Override + public void onResponse(final JSONObject response + ) { + displayLamp(response, view, i); + } + }); + } catch (JSONException e) { + e.printStackTrace(); + } break; case "PWM": - MaterialAlertDialogBuilder alert = new MaterialAlertDialogBuilder(mainActivity); - View viewAlert = mainActivity.getLayoutInflater().inflate(R.layout.alert_dialog_pwm, null); - RangeSlider readDuty = (RangeSlider) viewAlert.findViewById(R.id.range_slider_duty); - readDuty.setValues((float) Float.valueOf(pinValues.get(i))); - alert.setView(viewAlert); - alert.setPositiveButton("set", - new DialogInterface.OnClickListener() { - public void onClick( - final DialogInterface dialog, final int which) { - int value = readDuty.getValues().get(0).intValue(); - try { - JSONObject jsonObject = new JSONObject("{\"output\":{\"" + ((List) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i) + "\":\"" + value + "\"}}"); - mainActivity.uebergabe.write(deviceName, jsonObject, new Response.Listener() { - @Override - public void onResponse(JSONObject response) { - displayLamp(response, view, i); - textViewPin.setText(Html.fromHtml(((List) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i)+" (DC: " + pinValues.get(i) + "%) ")); - } - }); - } catch (JSONException e) { - e.printStackTrace();// aaaaa + MaterialAlertDialogBuilder alert = + new MaterialAlertDialogBuilder(mainActivity); + View viewAlert = mainActivity.getLayoutInflater(). + inflate(R.layout.alert_dialog_pwm, null); + RangeSlider readDuty = (RangeSlider) viewAlert. + findViewById(R.id.range_slider_duty); + readDuty.setValues((float) Float.valueOf(pinValues. + get(i))); + alert.setView(viewAlert); + alert.setPositiveButton("set", + new DialogInterface.OnClickListener() { + public void onClick( + final DialogInterface dialog, + final int which) { + int value = readDuty.getValues().get(0). + intValue(); + try { + JSONObject jsonObject = + new JSONObject( + "{\"output\":{\"" + + ((List) + (mainActivity.xml. + getPort(deviceName)). + get("pins")).get(i) + + "\":\"" + value + + "\"}}"); + mainActivity.uebergabe.write( + deviceName, jsonObject, + new Response. + Listener() { + @Override + public void onResponse( + final JSONObject response) { + displayLamp(response, view, + i); + textViewPin.setText(Html. + fromHtml(( + (List) ( + mainActivity.xml. + getPort(deviceName)). + get("pins")).get(i) + + " (DC: " + + pinValues.get(i) + + "%) ")); + } + }); + } catch (JSONException e) { + e.printStackTrace(); // aaaaa + } + dialog.cancel(); } - // Write your code here to execute after dialog + }); + alert.setNegativeButton("exit", + new DialogInterface.OnClickListener() { + public void onClick( + final DialogInterface dialog, + final int which) { dialog.cancel(); - } - }); - alert.setNegativeButton("exit", new DialogInterface.OnClickListener() { - public void onClick( - final DialogInterface dialog, final int which) { - dialog.cancel(); - } - }); - alert.show(); - break; + } + }); + alert.show(); + break; default: - Toast.makeText(mainActivity, deviceName + " is not an output ", Toast.LENGTH_SHORT).show(); - break; + Toast.makeText(mainActivity, deviceName + + " is not an output ", Toast.LENGTH_SHORT). + show(); + break; } } }); - - - - - return view; + } - -} - - - private void displayLamp(final JSONObject response, final View view, final int i) { - ImageView imageView = (ImageView) view.findViewById(R.id.images); - try { - JSONObject state = response.getJSONObject("state"); - if (pinValues.size() != 0) { - pinValues.clear(); - } - for (String pinName: ((List) mainActivity.xml.getPort(deviceName).get("pins"))){ - pinValues.add(state.getString(pinName)); - } - switch (pinValues.get(i)) { - case "1": - image = R.drawable.green_signal; - break; - case "0": - image = R.drawable.red_signal; - break; - case "100": - image = R.drawable.green_signal; - break; - default: - image = R.drawable.off_signal; - break; - } - imageView.setImageResource(image); - - } catch (JSONException e) { - // Richtigen log erstellen - e.printStackTrace(); - } - + private void displayLamp(final JSONObject response, final View view, + final int i) { + ImageView imageView = (ImageView) view.findViewById(R.id.images); + try { + JSONObject state = response.getJSONObject("state"); + if (pinValues.size() != 0) { + pinValues.clear(); + } + for (String pinName: ((List) mainActivity.xml. + getPort(deviceName).get("pins"))) { + pinValues.add(state.getString(pinName)); + } + switch (pinValues.get(i)) { + case "1": + image = R.drawable.green_signal; + break; + case "0": + image = R.drawable.red_signal; + break; + case "100": + image = R.drawable.green_signal; + break; + default: + image = R.drawable.off_signal; + break; + } + imageView.setImageResource(image); + } catch (JSONException e) { + // Richtigen log erstellen + e.printStackTrace(); } - - - + } } From 4073adce47e7f9744c3f350902f8de51a98306be Mon Sep 17 00:00:00 2001 From: m_broelemann Date: Wed, 6 Jan 2021 17:22:56 +0100 Subject: [PATCH 4/9] Code Conventions --- .../ui/visualization/MainListViewAdapter.java | 64 ++++++++++--------- 1 file changed, 35 insertions(+), 29 deletions(-) diff --git a/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java b/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java index 2537496..e5a124c 100644 --- a/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java +++ b/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java @@ -7,11 +7,8 @@ import android.widget.BaseAdapter; import android.widget.ImageView; import android.widget.LinearLayout; import android.widget.TextView; -import com.android.volley.Response; import com.example.aped.MainActivity; import com.example.aped.R; -import org.json.JSONException; -import org.json.JSONObject; import java.util.ArrayList; import java.util.List; @@ -95,10 +92,13 @@ public class MainListViewAdapter extends BaseAdapter { @Override public View getView(final int i, View view, final ViewGroup viewGroup) { - view = mainActivity.getLayoutInflater().inflate(R.layout.listview_layout, null); + view = mainActivity.getLayoutInflater().inflate(R.layout. + listview_layout, null); TextView textViewName = (TextView) view.findViewById(R.id.textName); - LinearLayout linearLayoutPin = (LinearLayout) view.findViewById(R.id.idLinearLayoutPins); - ImageView buttonViewFavoriten = (ImageView) view.findViewById(R.id.imageButtonFavoriten); + LinearLayout linearLayoutPin = (LinearLayout) view.findViewById(R.id. + idLinearLayoutPins); + ImageView buttonViewFavoriten = (ImageView) view.findViewById(R.id. + imageButtonFavoriten); if (favoriteMode == 0) { deviceName = mainActivity.xml.getDeviceNames().get(i); } else { @@ -111,37 +111,43 @@ public class MainListViewAdapter extends BaseAdapter { favoriteImage = android.R.drawable.btn_star_big_off; } buttonViewFavoriten.setOnClickListener(new View.OnClickListener() { - @Override - public void onClick(final View view) { + @Override + public void onClick(final View view) { - if (favoriteMode == 0) { - deviceName = mainActivity.xml.getDeviceNames().get(i); - } else { - List test = favoritenList; - deviceName = favoritenList.get(i); - } - if (mainActivity.favorite.getFavorites().contains(deviceName)) { - mainActivity.favorite.removeFavorite(deviceName); - favoriteImage = android.R.drawable.btn_star_big_off;buttonViewFavoriten.setImageResource( - favoriteImage); - } else { - mainActivity.favorite.addFavorite(deviceName); - favoriteImage = android.R.drawable.btn_star_big_on; - buttonViewFavoriten.setImageResource(favoriteImage); - } - } - }); + if (favoriteMode == 0) { + deviceName = mainActivity.xml.getDeviceNames().get(i); + } else { + List test = favoritenList; + deviceName = favoritenList.get(i); + } + if (mainActivity.favorite.getFavorites().contains(deviceName)) { + mainActivity.favorite.removeFavorite(deviceName); + favoriteImage = android.R.drawable.btn_star_big_off; + buttonViewFavoriten.setImageResource(favoriteImage); + } else { + mainActivity.favorite.addFavorite(deviceName); + favoriteImage = android.R.drawable.btn_star_big_on; + buttonViewFavoriten.setImageResource(favoriteImage); + } + } + }); PinView pinView = new PinView(mainActivity, deviceName); - for (int j = 0; j < ((List) mainActivity.xml.getPort(deviceName).get("pins")).size(); j++) { + for (int j = 0; j < ((List) mainActivity.xml. + getPort(deviceName).get("pins")).size(); j++) { linearLayoutPin.addView(pinView.getView(j)); } String name = null; - switch ((mainActivity.xml.getPort(deviceName)).get("protocol").toString()) { + switch ((mainActivity.xml.getPort(deviceName)).get("protocol"). + toString()) { case "PWM": - name = ((mainActivity.xml.getPort(deviceName)).get("protocol").toString() + ": " + deviceName + " (" + (mainActivity.xml.getPort(deviceName)).get("frequency").toString() + "Hz)"); + name = ((mainActivity.xml.getPort(deviceName)).get("protocol"). + toString() + ": " + deviceName + " (" + (mainActivity. + xml.getPort(deviceName)).get("frequency").toString() + + "Hz)"); break; default: - name = ((mainActivity.xml.getPort(deviceName)).get("protocol").toString() + ": " + deviceName); + name = ((mainActivity.xml.getPort(deviceName)).get("protocol"). + toString() + ": " + deviceName); break; } textViewName.setText(name); From 20c18ce389e38e49ed6efe71ae762a42b40f8802 Mon Sep 17 00:00:00 2001 From: m_broelemann Date: Wed, 6 Jan 2021 21:22:32 +0100 Subject: [PATCH 5/9] =?UTF-8?q?Code=20Conventions=20und=20auf=20Englisch?= =?UTF-8?q?=20=C3=BCbersetzt?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../java/com/example/aped/MainActivity.java | 16 ++++---- .../ui/visualization/MainListViewAdapter.java | 12 +++--- .../aped/ui/visualization/PinView.java | 39 ++++++++----------- ...t_dialog_pwm.xml => alert_dialog_duty.xml} | 0 ...ot_eingabe.xml => alert_dialog_ip_pot.xml} | 0 5 files changed, 30 insertions(+), 37 deletions(-) rename APED/app/src/main/res/layout/{alert_dialog_pwm.xml => alert_dialog_duty.xml} (100%) rename APED/app/src/main/res/layout/{alert_dialog_ip_pot_eingabe.xml => alert_dialog_ip_pot.xml} (100%) diff --git a/APED/app/src/main/java/com/example/aped/MainActivity.java b/APED/app/src/main/java/com/example/aped/MainActivity.java index dba4a1c..0725f6e 100644 --- a/APED/app/src/main/java/com/example/aped/MainActivity.java +++ b/APED/app/src/main/java/com/example/aped/MainActivity.java @@ -46,7 +46,7 @@ public class MainActivity extends AppCompatActivity { /** zur Verwendung von xml anstatt der direkten Einbindung.*/ public IXML xml; /** zur Verwendung von uebergabe anstatt der direkten Einbindung.*/ - public Communicator uebergabe; + public Communicator delivery; /** Handler for the custom user configurations. **/ public ConfigurationHandler configurationHandler; /** zur Verwendung von favorite anstatt der direkten Einbindung.*/ @@ -61,9 +61,9 @@ public class MainActivity extends AppCompatActivity { ensurePermissions(); setupConfigs(); favorite = configurationHandler; - uebergabe = new Communicator(configurationHandler.getAddress(), + delivery = new Communicator(configurationHandler.getAddress(), configurationHandler.getPort(), this); - uebergabe.downloadXML(); + delivery.downloadXML(); setContentView(R.layout.activity_main); Toolbar toolbar = findViewById(R.id.toolbar); setSupportActionBar(toolbar); @@ -105,7 +105,7 @@ public class MainActivity extends AppCompatActivity { MaterialAlertDialogBuilder(MainActivity.this); //alert.setTitle(R.string.action_set_connection); View view2 = LayoutInflater.from(MainActivity.this).inflate(R. - layout.alert_dialog_ip_pot_eingabe, null); + layout.alert_dialog_ip_pot, null); EditText ipAdress = (EditText) view2.findViewById(R.id. editTextIp); ipAdress.setText(configurationHandler.getAddress()); @@ -127,7 +127,7 @@ public class MainActivity extends AppCompatActivity { + ":" + configurationHandler. getPort() + " is set", Toast.LENGTH_SHORT).show(); - uebergabe = new Communicator( + delivery = new Communicator( configurationHandler.getAddress(), configurationHandler.getPort(), MainActivity.this); @@ -172,13 +172,15 @@ public class MainActivity extends AppCompatActivity { break; case R.id.action_download_xml: - uebergabe.downloadXML(); + delivery.downloadXML(); Toast.makeText(this, "Downloaded .xml", Toast.LENGTH_SHORT).show(); break; case R.id.action_upload_xml: try { - uebergabe.uploadXML(); + delivery.uploadXML(); + Toast.makeText(this, "Upload .xml executed", + Toast.LENGTH_SHORT).show(); } catch (FileNotFoundException e) { e.printStackTrace(); Toast.makeText(this, "Upload .xml failed", diff --git a/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java b/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java index e5a124c..609745c 100644 --- a/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java +++ b/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java @@ -19,19 +19,19 @@ public class MainListViewAdapter extends BaseAdapter { */ private MainActivity mainActivity; /** - * Welche ansicht gewählt wurde 0 für all IOs, 1 für favorite IOs. + * Which view was selected, 0 for all IOs, 1 for favorite IOs. */ private int favoriteMode; /** - * Name des devices für den aktuellen durchlauf. + * Name of the device for the current run. */ private String deviceName; /** - * Bild für Favorit oder nicht. + * Image for favorite or not. */ private int favoriteImage; /** - * Liste der beim öffnen der Favoritenansicht bestehenden Favoriten. + * List of favorites existing when opening the favorites view. */ private List favoritenList; @@ -46,9 +46,8 @@ public class MainListViewAdapter extends BaseAdapter { this.favoriteMode = pFavoriteMode; } - /** - * @return Anzahl der Anzeigen + * @return devices number */ @Override public int getCount() { @@ -117,7 +116,6 @@ public class MainListViewAdapter extends BaseAdapter { if (favoriteMode == 0) { deviceName = mainActivity.xml.getDeviceNames().get(i); } else { - List test = favoritenList; deviceName = favoritenList.get(i); } if (mainActivity.favorite.getFavorites().contains(deviceName)) { diff --git a/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java b/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java index 00793e4..6e826ee 100644 --- a/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java +++ b/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java @@ -18,26 +18,21 @@ import java.util.List; public class PinView { /** - * Einbinden der MainActivity. + * Include the MainActivity. */ private MainActivity mainActivity; /** - * Statusbild für den atuellen durchlauf. + * Image for state. */ private int image; /** - * Werte der Pins. + * Values of the pins. */ private List pinValues = new ArrayList<>(); /** - * Gerätenamen. + * Device name. */ private String deviceName; - /** - * DutyCycle. - */ - private String dutyValue; - /** * @param pMainActivity @@ -53,13 +48,12 @@ public class PinView { * @return view */ public View getView(final int i) { - dutyValue = ""; View view = mainActivity.getLayoutInflater().inflate(R.layout. pin_listview_layout, null); TextView textViewPin = (TextView) view.findViewById(R.id.textPin); textViewPin.setText(((List) (mainActivity.xml.getPort( deviceName)).get("pins")).get(i)); - mainActivity.uebergabe.read(deviceName, new Response. + mainActivity.delivery.read(deviceName, new Response. Listener() { @Override public void onResponse(final JSONObject response) { @@ -92,7 +86,7 @@ public class PinView { (mainActivity.xml.getPort( deviceName)).get("pins")). get(i) + "\":" + setState + "}}"); - mainActivity.uebergabe.write(deviceName, jsonObject, + mainActivity.delivery.write(deviceName, jsonObject, new Response.Listener() { @Override public void onResponse(final JSONObject response @@ -108,11 +102,12 @@ public class PinView { MaterialAlertDialogBuilder alert = new MaterialAlertDialogBuilder(mainActivity); View viewAlert = mainActivity.getLayoutInflater(). - inflate(R.layout.alert_dialog_pwm, null); + inflate(R.layout.alert_dialog_duty, null); RangeSlider readDuty = (RangeSlider) viewAlert. findViewById(R.id.range_slider_duty); readDuty.setValues((float) Float.valueOf(pinValues. - get(i))); + get(i).equals("None") ? "0" : pinValues.get(i)) + ); alert.setView(viewAlert); alert.setPositiveButton("set", new DialogInterface.OnClickListener() { @@ -123,15 +118,13 @@ public class PinView { intValue(); try { JSONObject jsonObject = - new JSONObject( - "{\"output\":{\"" - + ((List) - (mainActivity.xml. - getPort(deviceName)). - get("pins")).get(i) - + "\":\"" + value - + "\"}}"); - mainActivity.uebergabe.write( + new JSONObject("{\"output\":{\"" + + ((List) ( + mainActivity.xml.getPort( + deviceName)).get("pins") + ).get(i) + "\":\"" + + value + "\"}}"); + mainActivity.delivery.write( deviceName, jsonObject, new Response. Listener() { diff --git a/APED/app/src/main/res/layout/alert_dialog_pwm.xml b/APED/app/src/main/res/layout/alert_dialog_duty.xml similarity index 100% rename from APED/app/src/main/res/layout/alert_dialog_pwm.xml rename to APED/app/src/main/res/layout/alert_dialog_duty.xml diff --git a/APED/app/src/main/res/layout/alert_dialog_ip_pot_eingabe.xml b/APED/app/src/main/res/layout/alert_dialog_ip_pot.xml similarity index 100% rename from APED/app/src/main/res/layout/alert_dialog_ip_pot_eingabe.xml rename to APED/app/src/main/res/layout/alert_dialog_ip_pot.xml From 40bfeb64c03bd4ad4e2274ba445e5db5463eb835 Mon Sep 17 00:00:00 2001 From: m_broelemann Date: Wed, 6 Jan 2021 21:25:03 +0100 Subject: [PATCH 6/9] =?UTF-8?q?weitere=20Code=20Conventions=20und=20auf=20?= =?UTF-8?q?Englisch=20=C3=BCbersetzt?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../com/example/aped/ui/all_IOs/AllIOsFragment.java | 13 ++----------- .../aped/ui/favorite_IOs/FavoriteIOsFragment.java | 5 ++--- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/APED/app/src/main/java/com/example/aped/ui/all_IOs/AllIOsFragment.java b/APED/app/src/main/java/com/example/aped/ui/all_IOs/AllIOsFragment.java index 5aee9f7..bd22ca8 100644 --- a/APED/app/src/main/java/com/example/aped/ui/all_IOs/AllIOsFragment.java +++ b/APED/app/src/main/java/com/example/aped/ui/all_IOs/AllIOsFragment.java @@ -15,17 +15,9 @@ import com.example.aped.ui.visualization.MainListViewAdapter; public class AllIOsFragment extends Fragment { /** - * Einbinden der MainActivity. + * Include the MainActivity. */ private MainActivity mainActivity; - /** - * Genutzt für Signallampe. - */ - private int image; - /** - * Genutzt für Favoriten icons. - */ - private int favoriteImage; /** * @param inflater @@ -45,8 +37,7 @@ public class AllIOsFragment extends Fragment { MainListViewAdapter mainListViewAdapter = new MainListViewAdapter(mainActivity, 0); lv.setAdapter(mainListViewAdapter); - return view; } - } +} diff --git a/APED/app/src/main/java/com/example/aped/ui/favorite_IOs/FavoriteIOsFragment.java b/APED/app/src/main/java/com/example/aped/ui/favorite_IOs/FavoriteIOsFragment.java index 6d1593a..32a7591 100644 --- a/APED/app/src/main/java/com/example/aped/ui/favorite_IOs/FavoriteIOsFragment.java +++ b/APED/app/src/main/java/com/example/aped/ui/favorite_IOs/FavoriteIOsFragment.java @@ -15,7 +15,7 @@ import com.example.aped.ui.visualization.MainListViewAdapter; public class FavoriteIOsFragment extends Fragment { /** - * Einbinden der MainActivity. + * Include the MainActivity. */ private MainActivity mainActivity; /** @@ -27,7 +27,7 @@ public class FavoriteIOsFragment extends Fragment { */ public View onCreateView(final @NonNull LayoutInflater inflater, final ViewGroup container, - final Bundle savedInstanceState) { + final Bundle savedInstanceState) { this.mainActivity = (MainActivity) getActivity(); View view = inflater.inflate(R.layout.fragment_all_ios, container, false); @@ -35,7 +35,6 @@ public class FavoriteIOsFragment extends Fragment { MainListViewAdapter mainListViewAdapter = new MainListViewAdapter(mainActivity, 1); lv.setAdapter(mainListViewAdapter); - return view; } } From 1630c2fe8954b5d1460fee9a9bf6785d358dd4a0 Mon Sep 17 00:00:00 2001 From: m_broelemann Date: Wed, 6 Jan 2021 22:38:48 +0100 Subject: [PATCH 7/9] =?UTF-8?q?weitere=20Code=20Conventions=20und=20auf=20?= =?UTF-8?q?Englisch=20=C3=BCbersetzt=20+=20Komentare?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../java/com/example/aped/MainActivity.java | 156 +++++++++---- .../aped/ui/all_IOs/AllIOsFragment.java | 3 +- .../ui/favorite_IOs/FavoriteIOsFragment.java | 4 +- .../ui/visualization/MainListViewAdapter.java | 87 ++++---- .../aped/ui/visualization/PinView.java | 205 ++++++++---------- 5 files changed, 246 insertions(+), 209 deletions(-) diff --git a/APED/app/src/main/java/com/example/aped/MainActivity.java b/APED/app/src/main/java/com/example/aped/MainActivity.java index 0725f6e..fe19f15 100644 --- a/APED/app/src/main/java/com/example/aped/MainActivity.java +++ b/APED/app/src/main/java/com/example/aped/MainActivity.java @@ -2,7 +2,6 @@ package com.example.aped; import android.Manifest; import android.app.AlertDialog; -import android.content.DialogInterface; import android.content.Intent; import android.net.Uri; import android.os.Bundle; @@ -40,17 +39,17 @@ import static android.content.pm.PackageManager.PERMISSION_GRANTED; public class MainActivity extends AppCompatActivity { /** permission code for the storage permisson.*/ - private final int STORAGE_PERMISSION_CODE = 42; - /** was soll angezeigt werden in Navigation.*/ + private static final int STORAGE_PERMISSION_CODE = 42; + /** What should be displayed in navigation.*/ private AppBarConfiguration mAppBarConfiguration; - /** zur Verwendung von xml anstatt der direkten Einbindung.*/ - public IXML xml; - /** zur Verwendung von uebergabe anstatt der direkten Einbindung.*/ - public Communicator delivery; + /** To use xml instead of direct inclusion.*/ + private IXML xml; + /** To use delivery instead of direct inclusion.*/ + private Communicator delivery; /** Handler for the custom user configurations. **/ - public ConfigurationHandler configurationHandler; - /** zur Verwendung von favorite anstatt der direkten Einbindung.*/ - public IFAVORITES favorite; + private ConfigurationHandler configurationHandler; + /** To use favorite instead of direct inclusion.*/ + private IFAVORITES favorite; /** * @param savedInstanceState */ @@ -82,13 +81,22 @@ public class MainActivity extends AppCompatActivity { navController, mAppBarConfiguration); NavigationUI.setupWithNavController(navigationView, navController); } - /** Fügt Elemente zur Aktionsleiste hinzu, wenn diese vorhanden ist.*/ + + /** + *Adds elements to the action bar if it exists. + * @param menu + * @return + */ @Override public boolean onCreateOptionsMenu(final Menu menu) { getMenuInflater().inflate(R.menu.main, menu); return true; } - /**Navigation einrichten.*/ + + /** + * Set up navigation. + * @return + */ @Override public boolean onSupportNavigateUp() { NavController navController = Navigation.findNavController(this, @@ -96,53 +104,46 @@ public class MainActivity extends AppCompatActivity { return NavigationUI.navigateUp(navController, mAppBarConfiguration) || super.onSupportNavigateUp(); } - /**was soll bei click auf den jeweiligen itembutton passieren.*/ + /** + * What should happen when clicking on the respective itembutton. + * @param item + * @return + */ @Override public boolean onOptionsItemSelected(final @NonNull MenuItem item) { switch (item.getItemId()) { case R.id.action_set_IP: MaterialAlertDialogBuilder alert = new MaterialAlertDialogBuilder(MainActivity.this); - //alert.setTitle(R.string.action_set_connection); View view2 = LayoutInflater.from(MainActivity.this).inflate(R. layout.alert_dialog_ip_pot, null); - EditText ipAdress = (EditText) view2.findViewById(R.id. - editTextIp); + EditText ipAdress = view2.findViewById(R.id.editTextIp); ipAdress.setText(configurationHandler.getAddress()); - EditText port = (EditText) view2.findViewById(R.id. - editTextPort); + EditText port = view2.findViewById(R.id.editTextPort); port.setText(String.valueOf(configurationHandler.getPort())); alert.setView(view2); alert.setPositiveButton("set", - new DialogInterface.OnClickListener() { - public void onClick(final DialogInterface dialog, - final int which) { - // Write your code here to execute after dialog - configurationHandler.setAddress(ipAdress. - getText().toString()); - configurationHandler.setPort(Integer.parseInt( - port.getText().toString())); - Toast.makeText(getApplicationContext(), - configurationHandler.getAddress() - + ":" + configurationHandler. - getPort() + " is set", - Toast.LENGTH_SHORT).show(); - delivery = new Communicator( - configurationHandler.getAddress(), - configurationHandler.getPort(), - MainActivity.this); - } + (dialog, which) -> { + configurationHandler.setAddress(ipAdress.getText() + .toString()); + configurationHandler.setPort(Integer.parseInt(port + .getText().toString())); + Toast.makeText(getApplicationContext(), + configurationHandler.getAddress() + + ":" + configurationHandler. + getPort() + " is set", + Toast.LENGTH_SHORT).show(); + delivery = new Communicator( + configurationHandler.getAddress(), + configurationHandler.getPort(), + MainActivity.this); }); alert.setNegativeButton("exit", - new DialogInterface.OnClickListener() { - public void onClick(final DialogInterface dialog, - final int which) { - // Write your code here to execute after dialog - Toast.makeText(getApplicationContext(), - "exit clicked", - Toast.LENGTH_SHORT).show(); - dialog.cancel(); - } + (dialog, which) -> { + Toast.makeText(getApplicationContext(), + "exit clicked", + Toast.LENGTH_SHORT).show(); + dialog.cancel(); }); alert.show(); break; @@ -316,4 +317,69 @@ public class MainActivity extends AppCompatActivity { + e.getMessage()); } } + + /** + * Getter method for favorite. + * @return favorite get. + */ + public IFAVORITES getFavorite() { + return favorite; + } + + /** + * Setter method for favorite. + * @param pFavorite set. + */ + public void setFavorite(final IFAVORITES pFavorite) { + this.favorite = pFavorite; + } + + /** + * Getter method for xml. + * @return xml get. + */ + public IXML getXml() { + return xml; + } + + /** + * Setter method for xml. + * @param pXml set. + */ + public void setXml(final IXML pXml) { + this.xml = pXml; + } + + /** + * Getter method for delivery. + * @return delivery get. + */ + public Communicator getDelivery() { + return delivery; + } + + /** + * Setter method for delivery. + * @param pDelivery set. + */ + public void setDelivery(final Communicator pDelivery) { + this.delivery = pDelivery; + } + + /** + * Getter method for configurationHandler. + * @return configurationHandler get. + */ + public ConfigurationHandler getConfigurationHandler() { + return configurationHandler; + } + + /** + * Setter method for configurationHandler. + * @param pConfigurationHandler set. + */ + public void setConfigurationHandler(final ConfigurationHandler + pConfigurationHandler) { + this.configurationHandler = pConfigurationHandler; + } } diff --git a/APED/app/src/main/java/com/example/aped/ui/all_IOs/AllIOsFragment.java b/APED/app/src/main/java/com/example/aped/ui/all_IOs/AllIOsFragment.java index bd22ca8..8621cfc 100644 --- a/APED/app/src/main/java/com/example/aped/ui/all_IOs/AllIOsFragment.java +++ b/APED/app/src/main/java/com/example/aped/ui/all_IOs/AllIOsFragment.java @@ -20,6 +20,7 @@ public class AllIOsFragment extends Fragment { private MainActivity mainActivity; /** + * Compiling the data and calling up the AllIOs view. * @param inflater * @param container * @param savedInstanceState @@ -33,7 +34,7 @@ public class AllIOsFragment extends Fragment { this.mainActivity = (MainActivity) getActivity(); View view = inflater.inflate(R.layout.fragment_all_ios, container, false); - ListView lv = (ListView) view.findViewById(R.id.idListView); + ListView lv = view.findViewById(R.id.idListView); MainListViewAdapter mainListViewAdapter = new MainListViewAdapter(mainActivity, 0); lv.setAdapter(mainListViewAdapter); diff --git a/APED/app/src/main/java/com/example/aped/ui/favorite_IOs/FavoriteIOsFragment.java b/APED/app/src/main/java/com/example/aped/ui/favorite_IOs/FavoriteIOsFragment.java index 32a7591..13d31f4 100644 --- a/APED/app/src/main/java/com/example/aped/ui/favorite_IOs/FavoriteIOsFragment.java +++ b/APED/app/src/main/java/com/example/aped/ui/favorite_IOs/FavoriteIOsFragment.java @@ -19,7 +19,7 @@ public class FavoriteIOsFragment extends Fragment { */ private MainActivity mainActivity; /** - * + *Compiling the data and calling up the FavoriteIOs view. * @param inflater * @param container * @param savedInstanceState @@ -31,7 +31,7 @@ public class FavoriteIOsFragment extends Fragment { this.mainActivity = (MainActivity) getActivity(); View view = inflater.inflate(R.layout.fragment_all_ios, container, false); - ListView lv = (ListView) view.findViewById(R.id.idListView); + ListView lv = view.findViewById(R.id.idListView); MainListViewAdapter mainListViewAdapter = new MainListViewAdapter(mainActivity, 1); lv.setAdapter(mainListViewAdapter); diff --git a/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java b/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java index 609745c..cd65726 100644 --- a/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java +++ b/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java @@ -37,6 +37,7 @@ public class MainListViewAdapter extends BaseAdapter { /** + * Transfer of data to MainListViewAdapter. * @param pMainActivity * @param pFavoriteMode */ @@ -47,17 +48,18 @@ public class MainListViewAdapter extends BaseAdapter { } /** + * Set number of list elements. * @return devices number */ @Override public int getCount() { int devices; if (favoriteMode == 0) { - devices = mainActivity.xml.getDeviceNames().size(); + devices = mainActivity.getXml().getDeviceNames().size(); } else { - devices = mainActivity.favorite.getFavorites().size(); - favoritenList = new ArrayList<>(mainActivity.favorite. - getFavorites()); + devices = mainActivity.getFavorite().getFavorites().size(); + favoritenList = new ArrayList<>(mainActivity.getFavorite() + .getFavorites()); } return devices; } @@ -83,69 +85,68 @@ public class MainListViewAdapter extends BaseAdapter { } /** + * Device name display and favorite button and data sharing for state + * visitation. * @param i - * @param view + * @param pView * @param viewGroup * @return view */ @Override - public View getView(final int i, View view, + public View getView(final int i, final View pView, final ViewGroup viewGroup) { - view = mainActivity.getLayoutInflater().inflate(R.layout. - listview_layout, null); - TextView textViewName = (TextView) view.findViewById(R.id.textName); - LinearLayout linearLayoutPin = (LinearLayout) view.findViewById(R.id. - idLinearLayoutPins); - ImageView buttonViewFavoriten = (ImageView) view.findViewById(R.id. - imageButtonFavoriten); + View view = mainActivity.getLayoutInflater().inflate(R.layout + .listview_layout, null); + TextView textViewName = view.findViewById(R.id.textName); + LinearLayout linearLayoutPin = view.findViewById(R.id + .idLinearLayoutPins); + ImageView buttonViewFavoriten = view.findViewById(R.id + .imageButtonFavoriten); if (favoriteMode == 0) { - deviceName = mainActivity.xml.getDeviceNames().get(i); + deviceName = mainActivity.getXml().getDeviceNames().get(i); } else { - deviceName = mainActivity.favorite.getFavorites().get(i); + deviceName = mainActivity.getFavorite().getFavorites().get(i); } - if (mainActivity.favorite.getFavorites().contains(deviceName)) { + if (mainActivity.getFavorite().getFavorites().contains(deviceName)) { favoriteImage = android.R.drawable.btn_star_big_on; } else { favoriteImage = android.R.drawable.btn_star_big_off; } - buttonViewFavoriten.setOnClickListener(new View.OnClickListener() { - @Override - public void onClick(final View view) { - - if (favoriteMode == 0) { - deviceName = mainActivity.xml.getDeviceNames().get(i); - } else { - deviceName = favoritenList.get(i); - } - if (mainActivity.favorite.getFavorites().contains(deviceName)) { - mainActivity.favorite.removeFavorite(deviceName); - favoriteImage = android.R.drawable.btn_star_big_off; - buttonViewFavoriten.setImageResource(favoriteImage); - } else { - mainActivity.favorite.addFavorite(deviceName); - favoriteImage = android.R.drawable.btn_star_big_on; - buttonViewFavoriten.setImageResource(favoriteImage); - } + buttonViewFavoriten.setOnClickListener(view1 -> { + if (favoriteMode == 0) { + deviceName = mainActivity.getXml().getDeviceNames().get(i); + } else { + deviceName = favoritenList.get(i); + } + if (mainActivity.getFavorite().getFavorites() + .contains(deviceName)) { mainActivity.getFavorite() + .removeFavorite(deviceName); + favoriteImage = android.R.drawable.btn_star_big_off; + buttonViewFavoriten.setImageResource(favoriteImage); + } else { + mainActivity.getFavorite().addFavorite(deviceName); + favoriteImage = android.R.drawable.btn_star_big_on; + buttonViewFavoriten.setImageResource(favoriteImage); } }); PinView pinView = new PinView(mainActivity, deviceName); - for (int j = 0; j < ((List) mainActivity.xml. - getPort(deviceName).get("pins")).size(); j++) { + for (int j = 0; j < ((List) mainActivity.getXml() + .getPort(deviceName).get("pins")).size(); j++) { linearLayoutPin.addView(pinView.getView(j)); } String name = null; - switch ((mainActivity.xml.getPort(deviceName)).get("protocol"). + switch ((mainActivity.getXml().getPort(deviceName)).get("protocol"). toString()) { case "PWM": - name = ((mainActivity.xml.getPort(deviceName)).get("protocol"). - toString() + ": " + deviceName + " (" + (mainActivity. - xml.getPort(deviceName)).get("frequency").toString() - + "Hz)"); + name = ((mainActivity.getXml().getPort(deviceName)) + .get("protocol").toString() + ": " + deviceName + + " (" + (mainActivity.getXml().getPort(deviceName)) + .get("frequency").toString() + "Hz)"); break; default: - name = ((mainActivity.xml.getPort(deviceName)).get("protocol"). - toString() + ": " + deviceName); + name = ((mainActivity.getXml().getPort(deviceName)). + get("protocol").toString() + ": " + deviceName); break; } textViewName.setText(name); diff --git a/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java b/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java index 6e826ee..ddf6d2d 100644 --- a/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java +++ b/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java @@ -1,12 +1,10 @@ package com.example.aped.ui.visualization; -import android.content.DialogInterface; import android.text.Html; import android.view.View; import android.widget.ImageView; import android.widget.TextView; import android.widget.Toast; -import com.android.volley.Response; import com.example.aped.MainActivity; import com.example.aped.R; import com.google.android.material.dialog.MaterialAlertDialogBuilder; @@ -35,6 +33,7 @@ public class PinView { private String deviceName; /** + * Transfer of data to PinView. * @param pMainActivity * @param pDeviceName */ @@ -44,145 +43,115 @@ public class PinView { } /** + * Processing of the data in nzeigetezte of the pins frequencies and + * dutycycle as well as the status lamps. * @param i * @return view */ public View getView(final int i) { - View view = mainActivity.getLayoutInflater().inflate(R.layout. - pin_listview_layout, null); - TextView textViewPin = (TextView) view.findViewById(R.id.textPin); - textViewPin.setText(((List) (mainActivity.xml.getPort( - deviceName)).get("pins")).get(i)); - mainActivity.delivery.read(deviceName, new Response. - Listener() { - @Override - public void onResponse(final JSONObject response) { - displayLamp(response, view, i); - if ((mainActivity.xml.getPort(deviceName)).get("protocol"). - toString().equals("PWM")) { - textViewPin.setText(Html.fromHtml(((List) - (mainActivity.xml.getPort(deviceName)).get("pins")). - get(i) + " (DC: " + pinValues.get(i) + "%) " - )); - } + View view = mainActivity.getLayoutInflater().inflate(R.layout + .pin_listview_layout, null); + TextView textViewPin = view.findViewById(R.id.textPin); + textViewPin.setText(((List) (mainActivity.getXml(). + getPort(deviceName)).get("pins")).get(i)); + mainActivity.getDelivery().read(deviceName, response -> { + displayLamp(response, view, i); + if ((mainActivity.getXml().getPort(deviceName)).get("protocol") + .toString().equals("PWM")) { + textViewPin.setText(Html.fromHtml(((List) + (mainActivity.getXml().getPort(deviceName)).get("pins")) + .get(i) + " (DC: " + pinValues.get(i) + "%) " + )); } }); - view.setOnClickListener(new View.OnClickListener() { - @Override - public void onClick(final View view) { - switch ((mainActivity.xml.getPort(deviceName)).get("protocol"). - toString()) { - case "DO": + view.setOnClickListener(view1 -> { + switch ((mainActivity.getXml().getPort(deviceName)).get("protocol") + .toString()) { + case "DO": + try { + String setState; + if (pinValues.get(i).equals("0")) { + setState = "\"1\""; + } else { + setState = "\"0\""; + } + JSONObject jsonObject = new JSONObject( + "{\"output\":{\"" + ((List) (mainActivity + .getXml().getPort(deviceName)).get("pins")) + .get(i) + "\":" + setState + "}}"); + mainActivity.getDelivery().write(deviceName, + jsonObject, response -> displayLamp(response, + view1, i)); + } catch (JSONException e) { + e.printStackTrace(); // dd + } + break; + case "PWM": + MaterialAlertDialogBuilder alert = + new MaterialAlertDialogBuilder(mainActivity); + View viewAlert = mainActivity.getLayoutInflater() + .inflate(R.layout.alert_dialog_duty, null); + RangeSlider readDuty = viewAlert.findViewById(R.id + .range_slider_duty); + readDuty.setValues(Float.valueOf(pinValues.get(i) + .equals("None") ? "0" : pinValues.get(i)) + ); + alert.setView(viewAlert); + alert.setPositiveButton("set", (dialog, which) -> { + int value = readDuty.getValues().get(0).intValue(); try { - String setState = null; - if (pinValues.get(i).equals("0")) { - setState = "\"1\""; - } else { - setState = "\"0\""; - } JSONObject jsonObject = new JSONObject( "{\"output\":{\"" + ((List) - (mainActivity.xml.getPort( - deviceName)).get("pins")). - get(i) + "\":" + setState + "}}"); - mainActivity.delivery.write(deviceName, jsonObject, - new Response.Listener() { - @Override - public void onResponse(final JSONObject response - ) { - displayLamp(response, view, i); - } - }); - } catch (JSONException e) { - e.printStackTrace(); - } - break; - case "PWM": - MaterialAlertDialogBuilder alert = - new MaterialAlertDialogBuilder(mainActivity); - View viewAlert = mainActivity.getLayoutInflater(). - inflate(R.layout.alert_dialog_duty, null); - RangeSlider readDuty = (RangeSlider) viewAlert. - findViewById(R.id.range_slider_duty); - readDuty.setValues((float) Float.valueOf(pinValues. - get(i).equals("None") ? "0" : pinValues.get(i)) - ); - alert.setView(viewAlert); - alert.setPositiveButton("set", - new DialogInterface.OnClickListener() { - public void onClick( - final DialogInterface dialog, - final int which) { - int value = readDuty.getValues().get(0). - intValue(); - try { - JSONObject jsonObject = - new JSONObject("{\"output\":{\"" - + ((List) ( - mainActivity.xml.getPort( - deviceName)).get("pins") - ).get(i) + "\":\"" - + value + "\"}}"); - mainActivity.delivery.write( - deviceName, jsonObject, - new Response. - Listener() { - @Override - public void onResponse( - final JSONObject response) { - displayLamp(response, view, - i); - textViewPin.setText(Html. - fromHtml(( - (List) ( - mainActivity.xml. - getPort(deviceName)). - get("pins")).get(i) - + " (DC: " - + pinValues.get(i) - + "%) ")); - } - }); - } catch (JSONException e) { - e.printStackTrace(); // aaaaa - } - dialog.cancel(); - } - }); - alert.setNegativeButton("exit", - new DialogInterface.OnClickListener() { - public void onClick( - final DialogInterface dialog, - final int which) { - dialog.cancel(); + (mainActivity.getXml().getPort(deviceName)) + .get("pins")).get(i) + "\":\"" + value + + "\"}}"); + mainActivity.getDelivery().write(deviceName, + jsonObject, response -> { + displayLamp(response, view1, i); + textViewPin.setText(Html.fromHtml(( + (List) (mainActivity.getXml() + .getPort(deviceName)).get("pins")).get(i) + + " (DC: " + pinValues.get(i) + + "%) ")); + }); + } catch (JSONException e) { + e.printStackTrace(); // aaaaa } + dialog.cancel(); }); - alert.show(); - break; - default: - Toast.makeText(mainActivity, deviceName - + " is not an output ", Toast.LENGTH_SHORT). - show(); - break; - } - - + alert.setNegativeButton("exit", (dialog, + which) -> dialog.cancel()); + alert.show(); + break; + default: + Toast.makeText(mainActivity, deviceName + + " is not an output ", Toast.LENGTH_SHORT). + show(); + break; } + + }); return view; } + /** + * Method for the selection of the lamps. + * @param response + * @param view + * @param i + */ private void displayLamp(final JSONObject response, final View view, final int i) { - ImageView imageView = (ImageView) view.findViewById(R.id.images); + ImageView imageView = view.findViewById(R.id.images); try { JSONObject state = response.getJSONObject("state"); if (pinValues.size() != 0) { pinValues.clear(); } - for (String pinName: ((List) mainActivity.xml. - getPort(deviceName).get("pins"))) { + for (String pinName: ((List) mainActivity.getXml() + .getPort(deviceName).get("pins"))) { pinValues.add(state.getString(pinName)); } switch (pinValues.get(i)) { @@ -201,7 +170,7 @@ public class PinView { } imageView.setImageResource(image); } catch (JSONException e) { - // Richtigen log erstellen + // Richtigen log erstellen e.printStackTrace(); } } From fba2cac39ffdee23cf31a13bc5fc5302a6844f5a Mon Sep 17 00:00:00 2001 From: m_broelemann Date: Thu, 7 Jan 2021 17:34:26 +0100 Subject: [PATCH 8/9] error nachricht erstellt --- .../com/example/aped/ui/visualization/PinView.java | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java b/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java index ddf6d2d..b6d20a9 100644 --- a/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java +++ b/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java @@ -1,6 +1,7 @@ package com.example.aped.ui.visualization; import android.text.Html; +import android.util.Log; import android.view.View; import android.widget.ImageView; import android.widget.TextView; @@ -84,7 +85,9 @@ public class PinView { jsonObject, response -> displayLamp(response, view1, i)); } catch (JSONException e) { - e.printStackTrace(); // dd + Log.e("PinView", + "Error while generating JSON object: " + + e.getMessage()); } break; case "PWM": @@ -116,7 +119,9 @@ public class PinView { + "%) ")); }); } catch (JSONException e) { - e.printStackTrace(); // aaaaa + Log.e("PinView", + "Error while generating JSON object: " + + e.getMessage()); } dialog.cancel(); }); @@ -170,8 +175,8 @@ public class PinView { } imageView.setImageResource(image); } catch (JSONException e) { - // Richtigen log erstellen - e.printStackTrace(); + Log.e("PinView", "Error while generating JSON object: " + + e.getMessage()); } } } From 2f58640bff16890539ddd71c847c732fcab24691 Mon Sep 17 00:00:00 2001 From: m_broelemann Date: Thu, 7 Jan 2021 18:11:10 +0100 Subject: [PATCH 9/9] =?UTF-8?q?code=20conventions=20und=20Kommentare=20hin?= =?UTF-8?q?zugef=C3=BCgt?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../java/com/example/aped/MainActivity.java | 20 ++++++-- .../aped/communication/Communicator.java | 5 ++ .../aped/ui/all_IOs/AllIOsFragment.java | 5 +- .../ui/favorite_IOs/FavoriteIOsFragment.java | 4 +- .../ui/visualization/MainListViewAdapter.java | 26 ++++------ .../aped/ui/visualization/PinView.java | 18 ++----- .../com/example/aped/utils/TestFavorites.java | 48 ------------------- .../java/com/example/aped/utils/TestXML.java | 37 -------------- APED/app/src/main/res/values/drawables.xml | 24 +++++++--- APED/app/src/main/res/values/themes.xml | 12 +++-- 10 files changed, 65 insertions(+), 134 deletions(-) delete mode 100644 APED/app/src/main/java/com/example/aped/utils/TestFavorites.java delete mode 100644 APED/app/src/main/java/com/example/aped/utils/TestXML.java diff --git a/APED/app/src/main/java/com/example/aped/MainActivity.java b/APED/app/src/main/java/com/example/aped/MainActivity.java index fe19f15..773a33a 100644 --- a/APED/app/src/main/java/com/example/aped/MainActivity.java +++ b/APED/app/src/main/java/com/example/aped/MainActivity.java @@ -40,17 +40,25 @@ import static android.content.pm.PackageManager.PERMISSION_GRANTED; public class MainActivity extends AppCompatActivity { /** permission code for the storage permisson.*/ private static final int STORAGE_PERMISSION_CODE = 42; + /** What should be displayed in navigation.*/ private AppBarConfiguration mAppBarConfiguration; + /** To use xml instead of direct inclusion.*/ private IXML xml; + /** To use delivery instead of direct inclusion.*/ private Communicator delivery; + /** Handler for the custom user configurations. **/ private ConfigurationHandler configurationHandler; + /** To use favorite instead of direct inclusion.*/ private IFAVORITES favorite; + /** + * On create method of the main activity. + * Sets various displays and start settings. * @param savedInstanceState */ @Override @@ -66,14 +74,12 @@ public class MainActivity extends AppCompatActivity { setContentView(R.layout.activity_main); Toolbar toolbar = findViewById(R.id.toolbar); setSupportActionBar(toolbar); - DrawerLayout drawer = findViewById(R.id.drawer_layout); NavigationView navigationView = findViewById(R.id.nav_view); // Passing each menu ID as a set of Ids because each // menu should be considered as top level destinations. mAppBarConfiguration = new AppBarConfiguration.Builder( - R.id.nav_all_IOs, R.id.nav_your_IOs) - .setDrawerLayout(drawer) + R.id.nav_all_IOs, R.id.nav_your_IOs).setDrawerLayout(drawer) .build(); NavController navController = Navigation.findNavController(this, R.id.nav_host_fragment); @@ -285,6 +291,10 @@ public class MainActivity extends AppCompatActivity { } } + /** + * paul + * @param xmlFile + */ private void setDefaultXML(final File xmlFile) { try { InputStream inputStream = getAssets().open( @@ -301,6 +311,10 @@ public class MainActivity extends AppCompatActivity { } } + /** + * paul + * @param xmlFile + */ private void setDefaultConfig(final File xmlFile) { try { InputStream inputStream = getAssets().open( diff --git a/APED/app/src/main/java/com/example/aped/communication/Communicator.java b/APED/app/src/main/java/com/example/aped/communication/Communicator.java index 59634e2..208281c 100644 --- a/APED/app/src/main/java/com/example/aped/communication/Communicator.java +++ b/APED/app/src/main/java/com/example/aped/communication/Communicator.java @@ -162,6 +162,11 @@ public class Communicator { requestQueue.add(request); } + /** + * paul + * @param error + * @param method + */ private void handleError(final VolleyError error, final String method) { if (error instanceof ServerError) { Log.e("Communicator", "server error during " + method diff --git a/APED/app/src/main/java/com/example/aped/ui/all_IOs/AllIOsFragment.java b/APED/app/src/main/java/com/example/aped/ui/all_IOs/AllIOsFragment.java index 8621cfc..7fe3aaf 100644 --- a/APED/app/src/main/java/com/example/aped/ui/all_IOs/AllIOsFragment.java +++ b/APED/app/src/main/java/com/example/aped/ui/all_IOs/AllIOsFragment.java @@ -14,11 +14,8 @@ import com.example.aped.ui.visualization.MainListViewAdapter; public class AllIOsFragment extends Fragment { - /** - * Include the MainActivity. - */ + /** Include the MainActivity.*/ private MainActivity mainActivity; - /** * Compiling the data and calling up the AllIOs view. * @param inflater diff --git a/APED/app/src/main/java/com/example/aped/ui/favorite_IOs/FavoriteIOsFragment.java b/APED/app/src/main/java/com/example/aped/ui/favorite_IOs/FavoriteIOsFragment.java index 13d31f4..be89efa 100644 --- a/APED/app/src/main/java/com/example/aped/ui/favorite_IOs/FavoriteIOsFragment.java +++ b/APED/app/src/main/java/com/example/aped/ui/favorite_IOs/FavoriteIOsFragment.java @@ -14,9 +14,7 @@ import com.example.aped.R; import com.example.aped.ui.visualization.MainListViewAdapter; public class FavoriteIOsFragment extends Fragment { - /** - * Include the MainActivity. - */ + /** Include the MainActivity.*/ private MainActivity mainActivity; /** *Compiling the data and calling up the FavoriteIOs view. diff --git a/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java b/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java index cd65726..4fac387 100644 --- a/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java +++ b/APED/app/src/main/java/com/example/aped/ui/visualization/MainListViewAdapter.java @@ -14,28 +14,17 @@ import java.util.List; public class MainListViewAdapter extends BaseAdapter { - /** - * Einbinden der MainActivity. - */ + /** Include the MainActivity.*/ private MainActivity mainActivity; - /** - * Which view was selected, 0 for all IOs, 1 for favorite IOs. - */ + /** Which view was selected, 0 for all IOs, 1 for favorite IOs.*/ private int favoriteMode; - /** - * Name of the device for the current run. - */ + /** Name of the device for the current run.*/ private String deviceName; - /** - * Image for favorite or not. - */ + /** Image for favorite or not.*/ private int favoriteImage; - /** - * List of favorites existing when opening the favorites view. - */ + /** List of favorites existing when opening the favorites view.*/ private List favoritenList; - /** * Transfer of data to MainListViewAdapter. * @param pMainActivity @@ -65,6 +54,9 @@ public class MainListViewAdapter extends BaseAdapter { } /** + * This function is used to retrieve the data item associated. + * With the specified position in the data set to get the corresponding + * data of the specified location in the data collection. * @param position * @return */ @@ -75,6 +67,8 @@ public class MainListViewAdapter extends BaseAdapter { } /** + * As for the getItemId it returns the corresponding item element ID. + * The function returns a long item position value to the adapter. * @param position * @return */ diff --git a/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java b/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java index b6d20a9..a86e9d5 100644 --- a/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java +++ b/APED/app/src/main/java/com/example/aped/ui/visualization/PinView.java @@ -16,21 +16,13 @@ import java.util.ArrayList; import java.util.List; public class PinView { - /** - * Include the MainActivity. - */ + /** Include the MainActivity.*/ private MainActivity mainActivity; - /** - * Image for state. - */ + /** Image for state.*/ private int image; - /** - * Values of the pins. - */ + /** Values of the pins.*/ private List pinValues = new ArrayList<>(); - /** - * Device name. - */ + /** Device name.*/ private String deviceName; /** @@ -44,7 +36,7 @@ public class PinView { } /** - * Processing of the data in nzeigetezte of the pins frequencies and + * Processing of the data in displayed texts of the pins frequencies and * dutycycle as well as the status lamps. * @param i * @return view diff --git a/APED/app/src/main/java/com/example/aped/utils/TestFavorites.java b/APED/app/src/main/java/com/example/aped/utils/TestFavorites.java deleted file mode 100644 index ba2c5b7..0000000 --- a/APED/app/src/main/java/com/example/aped/utils/TestFavorites.java +++ /dev/null @@ -1,48 +0,0 @@ -package com.example.aped.utils; - -import java.util.ArrayList; -import java.util.List; - -/** - * implementation for the favorites interface - * does not use persistent storage! - */ -public class TestFavorites implements IFAVORITES { - - /** - * Liste der favoriten. - */ - private List favorites = new ArrayList<>(); - - /** - * @return - */ - @Override - public List getFavorites() { - return favorites; - } - - /** - * @param deviceName the name of the device to be added - * @return - */ - @Override - public String addFavorite(final String deviceName) { - if (!favorites.contains(deviceName)) { - favorites.add(deviceName); - } - return deviceName; - } - - /** - * @param deviceName the name of the device to be removed - * @return - */ - @Override - public String removeFavorite(final String deviceName) { - if (favorites.contains(deviceName)) { - favorites.remove(deviceName); - } - return deviceName; - } -} diff --git a/APED/app/src/main/java/com/example/aped/utils/TestXML.java b/APED/app/src/main/java/com/example/aped/utils/TestXML.java deleted file mode 100644 index 1207ba1..0000000 --- a/APED/app/src/main/java/com/example/aped/utils/TestXML.java +++ /dev/null @@ -1,37 +0,0 @@ -package com.example.aped.utils; - - -import java.util.ArrayList; -import java.util.Dictionary; -import java.util.Hashtable; -import java.util.List; - -public class TestXML implements IXML { - - /** - * @return - */ - @Override - public List getDeviceNames() { - List returnList = new ArrayList<>(); - returnList.add("stoff"); - returnList.add("schnaps"); - returnList.add("whatever"); - return returnList; - } - - /** - * @param deviceName the name of the relevant device - * @return - */ - @Override - public Dictionary getPort(final String deviceName) { - Dictionary returnDict = new Hashtable<>(); - returnDict.put("protocol", "DI"); - Dictionary pins = new Hashtable<>(); - pins.put("GPIO2", true); - pins.put("GPIO3", false); - returnDict.put("pins", pins); - return returnDict; - } -} diff --git a/APED/app/src/main/res/values/drawables.xml b/APED/app/src/main/res/values/drawables.xml index c4e4cea..c09c375 100644 --- a/APED/app/src/main/res/values/drawables.xml +++ b/APED/app/src/main/res/values/drawables.xml @@ -1,8 +1,20 @@ - @android:drawable/ic_menu_camera - @android:drawable/ic_menu_gallery - @android:drawable/ic_menu_slideshow - @android:drawable/ic_menu_manage - @android:drawable/ic_menu_share - @android:drawable/ic_menu_send + + @android:drawable/ic_menu_camera + + + @android:drawable/ic_menu_gallery + + + @android:drawable/ic_menu_slideshow + + + @android:drawable/ic_menu_manage + + + @android:drawable/ic_menu_share + + + @android:drawable/ic_menu_send + \ No newline at end of file diff --git a/APED/app/src/main/res/values/themes.xml b/APED/app/src/main/res/values/themes.xml index cf6ff74..a1f07ec 100644 --- a/APED/app/src/main/res/values/themes.xml +++ b/APED/app/src/main/res/values/themes.xml @@ -1,6 +1,7 @@ - @@ -19,7 +21,9 @@ true -