Code Conventions

This commit is contained in:
m_broelemann 2021-01-06 17:19:21 +01:00
parent feda184aa5
commit a0ac5d4d0e

View File

@ -3,22 +3,16 @@ package com.example.aped.ui.visualization;
import android.content.DialogInterface; import android.content.DialogInterface;
import android.text.Html; import android.text.Html;
import android.view.View; import android.view.View;
import android.widget.EditText;
import android.widget.ImageView; import android.widget.ImageView;
import android.widget.TextView; import android.widget.TextView;
import android.widget.Toast; import android.widget.Toast;
import androidx.annotation.NonNull;
import com.android.volley.Response; import com.android.volley.Response;
import com.example.aped.MainActivity; import com.example.aped.MainActivity;
import com.example.aped.R; import com.example.aped.R;
import com.google.android.material.dialog.MaterialAlertDialogBuilder; import com.google.android.material.dialog.MaterialAlertDialogBuilder;
import com.google.android.material.slider.RangeSlider; import com.google.android.material.slider.RangeSlider;
import org.json.JSONException; import org.json.JSONException;
import org.json.JSONObject; import org.json.JSONObject;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
@ -60,130 +54,162 @@ public class PinView {
*/ */
public View getView(final int i) { public View getView(final int i) {
dutyValue = ""; dutyValue = "";
View view = mainActivity.getLayoutInflater().inflate(R.layout.pin_listview_layout, null); View view = mainActivity.getLayoutInflater().inflate(R.layout.
pin_listview_layout, null);
TextView textViewPin = (TextView) view.findViewById(R.id.textPin); TextView textViewPin = (TextView) view.findViewById(R.id.textPin);
textViewPin.setText(((List<String>) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i)); textViewPin.setText(((List<String>) (mainActivity.xml.getPort(
mainActivity.uebergabe.read(deviceName, new Response.Listener<JSONObject>() { deviceName)).get("pins")).get(i));
mainActivity.uebergabe.read(deviceName, new Response.
Listener<JSONObject>() {
@Override @Override
public void onResponse(final JSONObject response) { public void onResponse(final JSONObject response) {
displayLamp(response, view, i); displayLamp(response, view, i);
if((mainActivity.xml.getPort(deviceName)).get("protocol").toString().equals("PWM")){ if ((mainActivity.xml.getPort(deviceName)).get("protocol").
textViewPin.setText(Html.fromHtml(((List<String>) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i)+" <b> (DC: " + pinValues.get(i) + "%) </b>")); toString().equals("PWM")) {
textViewPin.setText(Html.fromHtml(((List<String>)
(mainActivity.xml.getPort(deviceName)).get("pins")).
get(i) + " <b> (DC: " + pinValues.get(i) + "%) </b>"
));
} }
} }
}); });
view.setOnClickListener(new View.OnClickListener() { view.setOnClickListener(new View.OnClickListener() {
@Override @Override
public void onClick(final View view) { public void onClick(final View view) {
switch ((mainActivity.xml.getPort(deviceName)).get("protocol").toString()) { switch ((mainActivity.xml.getPort(deviceName)).get("protocol").
case "DO": toString()) {
case "DO":
try { try {
String setState = null; String setState = null;
if (pinValues.get(i).equals("0")) { if (pinValues.get(i).equals("0")) {
setState = "\"1\""; setState = "\"1\"";
} else { } else {
setState = "\"0\""; setState = "\"0\"";
}
JSONObject jsonObject = new JSONObject("{\"output\":{\"" + ((List<String>) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i) + "\":" + setState + "}}");
mainActivity.uebergabe.write(deviceName, jsonObject, new Response.Listener<JSONObject>() {
@Override
public void onResponse(final JSONObject response) {
displayLamp(response, view, i);
} }
}); JSONObject jsonObject = new JSONObject(
} catch (JSONException e) { "{\"output\":{\"" + ((List<String>)
e.printStackTrace(); (mainActivity.xml.getPort(
} deviceName)).get("pins")).
get(i) + "\":" + setState + "}}");
mainActivity.uebergabe.write(deviceName, jsonObject,
new Response.Listener<JSONObject>() {
@Override
public void onResponse(final JSONObject response
) {
displayLamp(response, view, i);
}
});
} catch (JSONException e) {
e.printStackTrace();
}
break; break;
case "PWM": case "PWM":
MaterialAlertDialogBuilder alert = new MaterialAlertDialogBuilder(mainActivity); MaterialAlertDialogBuilder alert =
View viewAlert = mainActivity.getLayoutInflater().inflate(R.layout.alert_dialog_pwm, null); new MaterialAlertDialogBuilder(mainActivity);
RangeSlider readDuty = (RangeSlider) viewAlert.findViewById(R.id.range_slider_duty); View viewAlert = mainActivity.getLayoutInflater().
readDuty.setValues((float) Float.valueOf(pinValues.get(i))); inflate(R.layout.alert_dialog_pwm, null);
alert.setView(viewAlert); RangeSlider readDuty = (RangeSlider) viewAlert.
alert.setPositiveButton("set", findViewById(R.id.range_slider_duty);
new DialogInterface.OnClickListener() { readDuty.setValues((float) Float.valueOf(pinValues.
public void onClick( get(i)));
final DialogInterface dialog, final int which) { alert.setView(viewAlert);
int value = readDuty.getValues().get(0).intValue(); alert.setPositiveButton("set",
try { new DialogInterface.OnClickListener() {
JSONObject jsonObject = new JSONObject("{\"output\":{\"" + ((List<String>) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i) + "\":\"" + value + "\"}}"); public void onClick(
mainActivity.uebergabe.write(deviceName, jsonObject, new Response.Listener<JSONObject>() { final DialogInterface dialog,
@Override final int which) {
public void onResponse(JSONObject response) { int value = readDuty.getValues().get(0).
displayLamp(response, view, i); intValue();
textViewPin.setText(Html.fromHtml(((List<String>) (mainActivity.xml.getPort(deviceName)).get("pins")).get(i)+" <b> (DC: " + pinValues.get(i) + "%) </b>")); try {
} JSONObject jsonObject =
}); new JSONObject(
} catch (JSONException e) { "{\"output\":{\""
e.printStackTrace();// aaaaa + ((List<String>)
(mainActivity.xml.
getPort(deviceName)).
get("pins")).get(i)
+ "\":\"" + value
+ "\"}}");
mainActivity.uebergabe.write(
deviceName, jsonObject,
new Response.
Listener<JSONObject>() {
@Override
public void onResponse(
final JSONObject response) {
displayLamp(response, view,
i);
textViewPin.setText(Html.
fromHtml((
(List<String>) (
mainActivity.xml.
getPort(deviceName)).
get("pins")).get(i)
+ " <b> (DC: "
+ pinValues.get(i)
+ "%) </b>"));
}
});
} catch (JSONException e) {
e.printStackTrace(); // aaaaa
}
dialog.cancel();
} }
// Write your code here to execute after dialog });
alert.setNegativeButton("exit",
new DialogInterface.OnClickListener() {
public void onClick(
final DialogInterface dialog,
final int which) {
dialog.cancel(); dialog.cancel();
} }
}); });
alert.setNegativeButton("exit", new DialogInterface.OnClickListener() { alert.show();
public void onClick( break;
final DialogInterface dialog, final int which) {
dialog.cancel();
}
});
alert.show();
break;
default: default:
Toast.makeText(mainActivity, deviceName + " is not an output ", Toast.LENGTH_SHORT).show(); Toast.makeText(mainActivity, deviceName
break; + " is not an output ", Toast.LENGTH_SHORT).
show();
break;
} }
} }
}); });
return view; return view;
}
private void displayLamp(final JSONObject response, final View view,
} final int i) {
ImageView imageView = (ImageView) view.findViewById(R.id.images);
try {
private void displayLamp(final JSONObject response, final View view, final int i) { JSONObject state = response.getJSONObject("state");
ImageView imageView = (ImageView) view.findViewById(R.id.images); if (pinValues.size() != 0) {
try { pinValues.clear();
JSONObject state = response.getJSONObject("state"); }
if (pinValues.size() != 0) { for (String pinName: ((List<String>) mainActivity.xml.
pinValues.clear(); getPort(deviceName).get("pins"))) {
} pinValues.add(state.getString(pinName));
for (String pinName: ((List<String>) mainActivity.xml.getPort(deviceName).get("pins"))){ }
pinValues.add(state.getString(pinName)); switch (pinValues.get(i)) {
} case "1":
switch (pinValues.get(i)) { image = R.drawable.green_signal;
case "1": break;
image = R.drawable.green_signal; case "0":
break; image = R.drawable.red_signal;
case "0": break;
image = R.drawable.red_signal; case "100":
break; image = R.drawable.green_signal;
case "100": break;
image = R.drawable.green_signal; default:
break; image = R.drawable.off_signal;
default: break;
image = R.drawable.off_signal; }
break; imageView.setImageResource(image);
} } catch (JSONException e) {
imageView.setImageResource(image); // Richtigen log erstellen
e.printStackTrace();
} catch (JSONException e) {
// Richtigen log erstellen
e.printStackTrace();
}
} }
}
} }